[PATCH] D87201: [clang-format] Add a option for the position of Java static import

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.

LGTM, I'm happy if @JakeMerdichAMD  is



================
Comment at: clang/include/clang/Format/Format.h:1708
+  /// \endcode
+  bool JavaStaticImportAfterImport;
+
----------------
bc-lee wrote:
> JakeMerdichAMD wrote:
> > MyDeveloperDay wrote:
> > > Can we consider changing the name or the option to make it clearer what its for?
> > > 
> > > `SortJavaStaticImport`
> > > 
> > > and make it an enumeration rather than true/false
> > > 
> > > `Before,After,Never`
> > > 
> > > There need to be a "don't touch it option (.e.g. Never)" that does what it does today (and that should be the default, otherwise we end up causing clang-format to change ALL java code" which could be 100's of millions of lines+
> > > 
> > > 
> > I'm confused, there is not currently a never option... Right now the behavior is always 'before', there is no 'after' or 'never'.
> > 
> > Making it an enum would probably be more ergonomic though, even there is no never option.
> If `SortIncludes` is `true`, it doesn't make sense to not touch Java static include.
> Making it an enum is also good for me.
> 
true.. it will sort it I assume one way or the other


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87201/new/

https://reviews.llvm.org/D87201