[PATCH] D66564: [clang-tidy] new altera struct pack align check

Frank Derry Wanye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 7 20:02:54 PDT 2020


ffrankies added a comment.

In D66564#2257635 <https://reviews.llvm.org/D66564#2257635>, @aaron.ballman wrote:

> In D66564#2256482 <https://reviews.llvm.org/D66564#2256482>, @ffrankies wrote:
>
>> In D66564#2256424 <https://reviews.llvm.org/D66564#2256424>, @Eugene.Zelenko wrote:
>>
>>> In D66564#2256423 <https://reviews.llvm.org/D66564#2256423>, @ffrankies wrote:
>>>
>>>> @Eugene.Zelenko I don't have commit access to the repository, could you please commit this check on our behalf?
>>>
>>> Sorry, I don't have it either. @aaron.ballman or @njames93 could do this for you.
>>
>> No problem. @aaron.ballman @njames93 Could one of you please commit this check on our behalf?
>
> Sorry for the hassle, but could you rebase again? I'm getting errors when I try to apply the patch.

Done. After rebasing, fixing the include statement in `StructPackAlignCheck.h` got rid of the errors that I saw.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66564/new/

https://reviews.llvm.org/D66564



More information about the cfe-commits mailing list