[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 7 11:02:57 PDT 2020


eduucaldas added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137
+    // Ignore the implicit default constructs.
+    if ((S->getNumArgs() == 0 || isa<CXXDefaultArgExpr>(S->getArg(0))) &&
+        S->getParenOrBraceRange().isInvalid())
----------------
gribozavr2 wrote:
> I don't quite understand which test is checking the CXXDefaultArgExpr case -- could you help me?
`CXXDefaultArgExpr` is in another [[ https://reviews.llvm.org/D87249 | patch ]]. Although I discovered while working on this it is as linked to Constructors as it is linked to function calls. As such I decided to add that in a separate patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86700/new/

https://reviews.llvm.org/D86700



More information about the cfe-commits mailing list