[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 7 09:11:43 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1136
+  bool WalkUpFromCXXConstructExpr(CXXConstructExpr *S) {
+    // Ignore the implicit default constructs.
+    if ((S->getNumArgs() == 0 || isa<CXXDefaultArgExpr>(S->getArg(0))) &&
----------------



================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137
+    // Ignore the implicit default constructs.
+    if ((S->getNumArgs() == 0 || isa<CXXDefaultArgExpr>(S->getArg(0))) &&
+        S->getParenOrBraceRange().isInvalid())
----------------
I don't quite understand which test is checking the CXXDefaultArgExpr case -- could you help me?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86700/new/

https://reviews.llvm.org/D86700



More information about the cfe-commits mailing list