[PATCH] D87201: [clang-format] Add a option for the position of Java static import

Jake Merdich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 7 08:21:54 PDT 2020


JakeMerdichAMD requested changes to this revision.
JakeMerdichAMD added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/include/clang/Format/Format.h:1705
+  /// \endcode
+  bool JavaStaticImportAfterImport;
+
----------------
3 things here:

1. Did you mix up the true and false cases?
2. (nit) You should also note that if this option is false, all static imports are before all non-static imports (as opposed to mixed together alphabetically). I was confused on first glance.
3. Please add this config option to FormatTests.cpp:ParsesConfigurationBools.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87201/new/

https://reviews.llvm.org/D87201



More information about the cfe-commits mailing list