[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 7 02:44:49 PDT 2020


eduucaldas added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:552
   [[::n::S s1]];
   [[n::S s2]];
 }
----------------
gribozavr2 wrote:
> Do we have tests for calling constructors with arguments?
> 
> `n::S s3(1, 2, 3);`
> `n::S s3{1, 2, 3};`
> 
> If not, please add them.
We have. I improved their coverage in the parent patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86700/new/

https://reviews.llvm.org/D86700



More information about the cfe-commits mailing list