[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

Fri Sep 4 15:06:07 PDT 2020

pzheng marked an inline comment as done.
pzheng added a comment.

In D87162#2257192 <https://reviews.llvm.org/D87162#2257192>, @MaskRay wrote:

> Can D83648 <https://reviews.llvm.org/D83648> be closed now?

Yes, I have closed it.

> BTW, can you describe a bit about your use cases? Forwarding options to gcc does not seem common nowadays...

It's probably not used very common, but we do have some baremetal use cases still relying on these flags to be propagated to GCC.

================
Comment at: clang/test/Driver/gcc_forward.c:4
 // RUN:   2>&1 | FileCheck --check-prefix=FORWARD %s
-// FORWARD: gcc{{[^"]*}}" "--coverage" "-fuse-ld=lld" "--ld-path=ld" "-nostdlib" "-rdynamic" "-static" "-static-pie" "-o" "a.out" "{{.*}}.o" "-e" "_start" "-r"
+// FORWARD: gcc{{[^"]*}}" "-specs=nosys.specs" "-nostartfiles" "--coverage" "-fuse-ld=lld" "--ld-path=ld" "-nostdlib" "-rdynamic" "-static" "-static-pie" "-o" "a.out" "{{.*}}.o" "-e" "_start" "-r"

----------------
MaskRay wrote:
> Moving nostartfiles before nostdlib to keep an alphabetical order.
> 
> Similarly, specs can precede static.
Thanks for pointing this out. I did not realize the flags are ordered. Will update the patch shortly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87162/new/

https://reviews.llvm.org/D87162