[PATCH] D87006: [clang-format][NFC] Store FormatToken::Type as an enum instead of bitfield

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 4 08:05:45 PDT 2020


MyDeveloperDay added a comment.

I'm not a C++ language lawyer so I'm not sure which standard introduce enum inheritance? (maybe its something we could always do?), if its a recent change we just need to ensure we are conforming to the C++ version that is needed to build clang.

Apart from that it looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87006/new/

https://reviews.llvm.org/D87006



More information about the cfe-commits mailing list