[PATCH] D87103: [test] Use %t instead of %T to remove race conditions between config-file3.c and target-override.c

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 3 11:22:35 PDT 2020


MaskRay created this revision.
MaskRay added reviewers: dblaikie, nemanjai.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
MaskRay requested review of this revision.

Both tests operate on `%T/testbin`. If the two tests run concurrently,
one may fail.

This is likely the root cause of flaky failures reported by
https://lists.llvm.org/pipermail/llvm-dev/2020-September/144781.html

https://llvm.org/docs/CommandGuide/lit.html says:

`%T	parent directory of %t (not unique, deprecated, do not use)`


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87103

Files:
  clang/test/Driver/config-file3.c
  clang/test/Driver/target-override.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87103.289772.patch
Type: text/x-patch
Size: 8870 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200903/52c28654/attachment.bin>


More information about the cfe-commits mailing list