[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 3 10:39:17 PDT 2020


rjmccall added a comment.

I didn't see the specific example, sorry.  I agree that my description is more applicable to builtins in the `__builtin` namespace, which describes most of the builtins with custom typechecking.  Is the problem just `__va_start`?

If we have to treat all declarations as builtins for the custom-typechecking builtins just to land this patch, I don't think that's the worst result in the world, and we can incrementally go from there.  `__va_start` actually has a signature, it just effectively has optional arguments, which is something we could definitely teach the builtins database and signature-matcher about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77491/new/

https://reviews.llvm.org/D77491



More information about the cfe-commits mailing list