[PATCH] D84455: [Concepts] Fix a deserialization crash.

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 1 17:09:06 PDT 2020


aaronpuchert added a comment.

> in some cases (e.g. implicit deduction guide templates synthesized from the constructor), hasTypeConstraint returns true, and getTypeConstraint returns a nullptr.

If that's the case, can we reproduce this with a parsed AST? I've only seen this error on deserialized ASTs, so I'm not sure it isn't in fact a serialization issue.

But I agree with you that `hasTypeConstraint` returning `HasTypeConstraint` and `getTypeConstraint` checking `TypeConstraintInitialized` makes the interface easy to misuse. Haven't seen anywhere in the AST a concept of having, but not having initialized a property—either it's there or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84455/new/

https://reviews.llvm.org/D84455



More information about the cfe-commits mailing list