[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 1 11:42:54 PDT 2020


bruno added reviewers: rsmith, v.g.vassilev.
bruno added inline comments.


================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:870
+  // definition (which is required for `setPure`).
+  const bool pure = Record.readInt();
   FD->setHasInheritedPrototype(Record.readInt());
----------------
`pure` -> `Pure`


================
Comment at: clang/test/Modules/set-pure-crash.cpp:2
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -O0 -emit-llvm -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -x c++ -I %S/Inputs/set-pure-crash -verify %s -o %t
+
----------------
To speed this up a little, instead of `-O0 -emit-llvm` just use `-fsyntax-only`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86853/new/

https://reviews.llvm.org/D86853



More information about the cfe-commits mailing list