[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 1 10:51:09 PDT 2020


bruno added inline comments.


================
Comment at: clang/test/Modules/explicit-module-maps.cpp:4
+
+// RUN: %clang_cc1 -fmodule-map-file=%S/Inputs/explicit-module-maps/invalid.modulemap -verify %s
+// expected-no-diagnostics
----------------
Minor suggestion here given the content of the file is pretty simple, how about something along these lines:

```
// RUN: rm -rf %t
// RUN: mkdir %t
// RUN: echo 'DOES NOT PARSE!' > %t/invalid.modulemap
// RUN: %clang_cc1 -fmodule-map-file=%t/invalid.modulemap -verify %s

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86802/new/

https://reviews.llvm.org/D86802



More information about the cfe-commits mailing list