[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 31 13:10:15 PDT 2020


phosek added a comment.

This was discussed when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` was introduced and there was a pushback against changing the driver behavior depending on the value of that option, so if we're going to reverse that decision for BareMetal, I think that deserves a broader discussion.



================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:163
+  CmdArgs.push_back(
+      Args.MakeArgString("-lclang_rt.builtins-" + getTriple().getArchName()));
+#endif
----------------
Is there a reason why BareMetal doesn't just use https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/ToolChain.cpp#L462 like all other drivers, and instead re-implements the runtime library lookup logic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86877/new/

https://reviews.llvm.org/D86877



More information about the cfe-commits mailing list