[PATCH] D84603: Thread safety analysis: More consistent warning message

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 31 06:27:25 PDT 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a suggestion for a comment, thank you!



================
Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:205
 
+  /// Warn when calling a function that the negative capability is not held.
+  /// \param D -- The decl for the function requiring the negative capability.
----------------
aaronpuchert wrote:
> Should probably be "**a** negative capability", silly copy-and-paste error.
`Warn when calling a function and a negative capability is not held.`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84603/new/

https://reviews.llvm.org/D84603



More information about the cfe-commits mailing list