[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 28 12:58:53 PDT 2020


bruno added inline comments.


================
Comment at: clang/lib/Frontend/FrontendAction.cpp:814
+        CI.getPreprocessor().getHeaderSearchInfo().loadModuleMapFile(
+            *File, /*IsSystem*/ false);
+      else
----------------
andrewjcg wrote:
> bruno wrote:
> > Is this clang-formatted? 
> Ahh, yeah.  Should I avoid this sort of thing (and e.g. instead do this in explicit codemod/refactoring diffs)?
It's fine in this case cause it's relevant as part of your changes (indentation for the block will change anyways), just double checking on the final formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86802/new/

https://reviews.llvm.org/D86802



More information about the cfe-commits mailing list