[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Ed Maste via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 28 11:56:01 PDT 2020


emaste added inline comments.


================
Comment at: clang/lib/Basic/Targets.cpp:361-362
       return new LinuxTargetInfo<PPC64TargetInfo>(Triple, Opts);
+    case llvm::Triple::FreeBSD:
+      return new FreeBSDTargetInfo<PPC64TargetInfo>(Triple, Opts);
     case llvm::Triple::NetBSD:
----------------
Bdragon28 wrote:
> Bdragon28 wrote:
> > emaste wrote:
> > > List was previously in alpha order
> > Yes. However, I am following the ordering of the ppc64 and powerpc triples.
> that is, the ordering is "Linux, the BSDs, Embedded targets, Commercial targets" for ppc*.
Ok, as long as it's consistent I'm happy with it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73425/new/

https://reviews.llvm.org/D73425



More information about the cfe-commits mailing list