[PATCH] D85810: [clang] Pass-through remarks options to linker

[Wei Wang via Phabricator via cfe-commits]

weiwang added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:596
+  // Handle remark diagnostics on screen options: '-Rpass-*'.
+  if (usesRpassOptions(Args))
+    renderRpassOptions(Args, CmdArgs);
----------------
tejohnson wrote:
> Is this guard needed? It looks like renderRpassOptions will do the right thing if none are specified (won't add anything). Right now you end up checking each one a second time if any are enabled.
You are right! I will remove the redundant check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85810/new/

https://reviews.llvm.org/D85810