[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D82657#2240603 <https://reviews.llvm.org/D82657#2240603>, @vvereschaka wrote:

> Hi @hokein,
>
> sorry, but looks like your changes break one of libc++ tests on ARM cross toolchain build on Windows: `libc++::function_type_default_deleter.fail.cpp`
> Here is the first failed build: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/945
>
> I didn't get how these changes affects the failing test, but reverting of your commit fixes the problem.
>
> Would you take a look and fix the problem? or revert the changes if it is going to take a lot of time to resolve?
>
> Here is the command line to build the test:
>
>   C:/buildbot/temp/build/./bin/clang++.exe C:/buildbot/temp/llvm-project/libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp -v --sysroot=C:/buildbot/.arm-ubuntu --target=armv7-linux-gnueabihf -include C:/buildbot/temp/build/runtimes/runtimes-bins/libcxx\__config_site -include C:/buildbot/temp/llvm-project/libcxx\test\support\nasty_macros.h -nostdinc++ -IC:/buildbot/temp/llvm-project/libcxx\include -IC:/buildbot/temp/build/runtimes/runtimes-bins/libcxx\include\c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -IC:/buildbot/temp/llvm-project/libcxx\test/support -Werror -Wall -Wextra -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -std=c++2a -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only -Wno-error -Xclang -verify -Xclang -verify-ignore-unexpected=note -ferror-limit=0
>
> Here is the result output:
>
>   clang -cc1 version 12.0.0 based upon LLVM 12.0.0git default target armv7-linux-gnueabihf
>   ignoring nonexistent directory "C:/buildbot/.arm-ubuntu/usr/local/include"
>   ignoring nonexistent directory "C:/buildbot/.arm-ubuntu/include"
>   #include "..." search starts here:
>   #include <...> search starts here:
>    C:/buildbot/temp/llvm-project/libcxx\include
>    C:/buildbot/temp/build/runtimes/runtimes-bins/libcxx\include\c++build
>    C:/buildbot/temp/llvm-project/libcxx\test/support
>    C:\buildbot\temp\build\lib\clang\12.0.0\include
>    C:/buildbot/.arm-ubuntu/usr/include/arm-linux-gnueabihf
>    C:/buildbot/.arm-ubuntu/usr/include
>   End of search list.
>   error: 'error' diagnostics seen but not expected:
>     File C:/buildbot/temp/llvm-project/libcxx\include\memory Line 2033: no member named 'value' in 'std::__1::is_empty<std::__1::__compressed_pair<void
>   (*)(Tag<5>), std::__1::default_delete<void (Tag<5>)>>>'
>   1 error generated.

thanks! I have a proposal fix in D86685 <https://reviews.llvm.org/D86685>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82657/new/

https://reviews.llvm.org/D82657