[PATCH] D85031: [builtins] Unify the softfloat division implementation

Serge Pavlov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 26 06:41:54 PDT 2020


sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.

LGTM.

I don't fully understand the magic of fixing possible overflow, I hope you made enough investigation and testing to be sure it works as expected.
Please wait a couple of days before commit, so that other reviewers could make their notes.



================
Comment at: compiler-rt/lib/builtins/fp_div_impl.inc:142
+  // An error due to truncated C + an error due to truncated x_UQ0_hw:
+  // e_0 <= 3/4 - 1/sqrt(2) + 2^-W0 + 2^-HW
+
----------------
Should the right part contain `1/b`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85031/new/

https://reviews.llvm.org/D85031



More information about the cfe-commits mailing list