[PATCH] D85735: [OpenMP] Context selector extensions for template functions

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 25 16:39:56 PDT 2020


ABataev added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:10042
   void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope(
-      FunctionDecl *FD, FunctionDecl *BaseFD);
+      Decl *D, SmallVectorImpl<FunctionDecl *> &Bases);
 
----------------
JonChesterfield wrote:
> SmallVectorImpl => SmallVector?
It is a good practice to pass SmallVectors as SmallVectorImpl to make it independent of concrete SmallVector template specialization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85735/new/

https://reviews.llvm.org/D85735



More information about the cfe-commits mailing list