[PATCH] D86558: [OPENMP]Add support for allocate vars in untied tasks.

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 25 10:47:57 PDT 2020


ABataev created this revision.
ABataev added a reviewer: jdoerfert.
Herald added subscribers: guansong, yaxunl.
Herald added a project: clang.
ABataev requested review of this revision.
Herald added a subscriber: sstefan1.

Local vars, marked with pragma allocate, mustbe allocate by the call of
the runtime function and cannot be allocated as other local variables.
Instead, we allocate a space for the pointer in private record and store
the address, returned by kmpc_alloc call in this pointer.
So, for untied tasks

  #pragma omp task untied
  {
    S s;
     #pragma omp allocate(s) allocator(allocator)
    s = x;
  }

compiler generates something like this:

  struct task_with_privates {
    S *ptr;
  };
  
  void entry(task_with_privates *p) {
    S *s = p->s;
    switch(partid) {
    case 1:
      p->s = (S*)kmpc_alloc();
      kmpc_omp_task();
      br exit;
    case 2:
      *s = x;
      kmpc_omp_task();
      br exit;
    case 2:
      ~S(s);
      kmpc_free((void*)s);
      br exit;
    }
  exit:
  }


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86558

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/CodeGen/CGOpenMPRuntime.h
  clang/lib/CodeGen/CGStmtOpenMP.cpp
  clang/test/OpenMP/allocate_codegen.cpp
  clang/test/OpenMP/for_lastprivate_codegen.cpp
  clang/test/OpenMP/for_linear_codegen.cpp
  clang/test/OpenMP/for_reduction_codegen_UDR.cpp
  clang/test/OpenMP/parallel_firstprivate_codegen.cpp
  clang/test/OpenMP/parallel_private_codegen.cpp
  clang/test/OpenMP/task_codegen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86558.287711.patch
Type: text/x-patch
Size: 28444 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200825/695ebe79/attachment-0001.bin>


More information about the cfe-commits mailing list