[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 24 09:56:06 PDT 2020


aganea added a comment.

Thanks, one more minor thing and it should be good to go.



================
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:764
 
   // Check the environment first, since that's probably the user telling us
   // what they want to use.
----------------
Please update these comments, and maybe state that the order of execution is important (for the reason you mention above)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85998/new/

https://reviews.llvm.org/D85998



More information about the cfe-commits mailing list