[PATCH] D86223: [analyzer][z3] Use more elaborate Z3 variable names

[Balázs Benics via Phabricator via cfe-commits]

steakhal updated this revision to Diff 287303.
steakhal retitled this revision from "[analyzer][z3] Use more elaborate z3 variable names in debug build" to "[analyzer][z3] Use more elaborate Z3 variable names".
steakhal edited the summary of this revision.
steakhal added a comment.

In D86223#2232681 <https://reviews.llvm.org/D86223#2232681>, @mikhail.ramalho wrote:

> In D86223#2231991 <https://reviews.llvm.org/D86223#2231991>, @steakhal wrote:
>
>> In D86223#2231959 <https://reviews.llvm.org/D86223#2231959>, @mikhail.ramalho wrote:
>>
>>> I don't mind having it for release builds as well, why are you applying it only for debug builds?
>>
>> It might introduce a slight overhead since Z3 will parse longer the symbol names.
>
> That overhead should be negligible, in the worst case you are adding just a few extra characters to the variable's name.
>
> I rather have it for release builds as well so we don't introduce different outputs depending on the build options, and we can improve debugging for release builds as well.
>
> Also as a bonus, we don't have to change the test scripts for a single test.

Fixed.

---

Revision updated:

- Use the prettier symbol names unconditionally
- Revert changes to the test infra


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86223/new/

https://reviews.llvm.org/D86223

Files:
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConstraintManager.h
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymExpr.h
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
  clang/lib/StaticAnalyzer/Core/SymbolManager.cpp
  clang/test/Analysis/z3/pretty-dump.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86223.287303.patch
Type: text/x-patch
Size: 7142 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200824/3a4cc8fb/attachment.bin>