[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

Anatoly Trosinenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 21 07:40:37 PDT 2020


atrosinenko added inline comments.


================
Comment at: compiler-rt/lib/builtins/int_mulv_impl.inc:1
-//===-- mulvdi3.c - Implement __mulvdi3 -----------------------------------===//
+//===-- int_mulv_impl.inc - Implement __mulv[sdt]i3 -----------------------===//
 //
----------------
MaskRay wrote:
> `---*- C++ -*-===//`
Thanks. It really is a C source (there are no C++ sources in the builtins library, as far as I know), still almost all other .inc files in this directory are actually marked with `-*- C -*-`, so explicitly marked this one as well.

Interestingly, `int_div_impl.inc` is the only one such file **explicitly** marked as C++, but it is probably a mistake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86277/new/

https://reviews.llvm.org/D86277



More information about the cfe-commits mailing list