[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/Basic/Targets/OSTargets.h:743
+    Builder.defineMacro("__BFP__");
+    // FIXME: __BOOL__ should be defined under strict -std=c89.
+    Builder.defineMacro("__BOOL__");
----------------
MaskRay wrote:
> What is strict -std=c89? `!Opts.C99` ?
The comment has a typo. The macro should //not// be defined with strict C89 modes.

> What is strict -std=c89? `!Opts.C99` ?

In the context of this macro, "strict C89" means `!Opts.C99` and the severity of `ext_c99_feature` diagnostics is at least an error. This occurs, for example, with `-std=gnu89 -Werror=c99-extensions`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85324/new/

https://reviews.llvm.org/D85324