[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 20 13:06:07 PDT 2020


phosek added a comment.

In D86308#2228917 <https://reviews.llvm.org/D86308#2228917>, @tambre wrote:

> I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is enabled by compiler-rt anyway and CMake can recognize the files as assembly anyway.

Can we remove that function altogether then?

> @teemperor Could you give this a try? If this doesn't work, could you upload the Ninja file for me to investigate? I've never used macOS so the simulators and many architectures at once is quite new to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86308/new/

https://reviews.llvm.org/D86308



More information about the cfe-commits mailing list