[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

1 comment, otherwise seems alright to me.



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752
   StringRef TargetCPU = getTarget().getTargetOpts().CPU;
+  StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU;
   std::vector<std::string> Features;
----------------
Does this lead to a situation in 'attribute-target' where we have a 'tune' setting to a processor that is 'before' the 'TargetCPU'?  Should this enforce some sort of hierarchy to make sure we only do it if it is 'newer' (read, more feature rich) than the target?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85384/new/

https://reviews.llvm.org/D85384