[PATCH] D85826: [clang] Make signature help work with dependent args

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 17 01:02:01 PDT 2020


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

thanks, looks better.



================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5513
   for (OverloadCandidate &Candidate : CandidateSet) {
-    if (Candidate.Function && Candidate.Function->isDeleted())
-      continue;
+    if (Candidate.Function) {
+      if (Candidate.Function->isDeleted())
----------------
nit: use early return.

```
if (!Candidate.Function) {
  continue;
}
...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85826/new/

https://reviews.llvm.org/D85826



More information about the cfe-commits mailing list