[PATCH] D74361: [Clang] Undef attribute for global variables

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 14 08:49:54 PDT 2020


JonChesterfield added a comment.

In D74361#2218258 <https://reviews.llvm.org/D74361#2218258>, @erichkeane wrote:

> I did a little debugging, and the problem is the template itself isn't a complete type

That's clear cut then, thanks. This patch was limited to trivially constructible types, and we don't know whether the type is trivially constructible if it's incomplete. Thus it does require complete types and we're missing a check in sema


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74361/new/

https://reviews.llvm.org/D74361



More information about the cfe-commits mailing list