[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

Endre Fülöp via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 01:29:28 PDT 2020


gamesh411 added a comment.

Aside  from infrastructural questions which I am not qualified ( nor particularly knowledgeable :3 ) to address, this looks good to me.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp:77
 
+  unsigned ArgNum = 999;
+
----------------
999 seems a bit arbitrary here, consider using std::numeric_limits<unsigned>::max(), or llvm::Optional<unsigned>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77229/new/

https://reviews.llvm.org/D77229



More information about the cfe-commits mailing list