[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 12 03:38:51 PDT 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:210
         GetClangTidyOptions(*TFS.view(/*CWD=*/llvm::None), File);
+  if (!Opts.ClangTidyOpts.Checks) {
+    // If the user hasn't configured clang-tidy checks at all, including
----------------
njames93 wrote:
> Should the `!` be removed the branches be swapped? Just looks cleaner imo, WDYT? 
SGTM, will address once we've settled on the idea with Sam.

(and let this be a ping to him :D @sammccall )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83224/new/

https://reviews.llvm.org/D83224



More information about the cfe-commits mailing list