[PATCH] D85728: [Analyzer][WIP] Support for the new variadic isa<> and isa_and_nod_null<> in CastValueChecker

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 11 06:39:33 PDT 2020


baloghadamsoftware added a comment.

My proposal is the following: do not store the casing info between pointers and references but the underlying types themselves. There are two ways to implement this: in the checkers using it (currently only this one) or behind the API of `DynamicCastInfo`. Maybe the latter is more appropriate.

To be fully correct we should not only change the `DynamicCastInfo` but also the `DynamicTypeInfo`: if the dynamic type of an object behind a pointer is known, then it remains the same also if we get a reference from the pointer or substitute a type for a template type parameter with it. (We can create new pointer or reference type using `ASTContext`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85728/new/

https://reviews.llvm.org/D85728



More information about the cfe-commits mailing list