[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 11 06:24:32 PDT 2020


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1620
     // Macros can be very spammy, so we only support prefix completion.
     // We won't end up with underfull index results, as macros are sema-only.
+    if (((C.SemaResult &&
----------------
this comment seems stale, macros are not sema-only now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85721/new/

https://reviews.llvm.org/D85721



More information about the cfe-commits mailing list