[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 10 21:36:37 PDT 2020


nridge added inline comments.


================
Comment at: clang/include/clang/AST/ExprCXX.h:4587
+      return RParenLoc;
+    return getPattern()->getEndLoc();
+  }
----------------
Wouldn't `EllipsisLoc` be more accurate?


================
Comment at: clang/test/AST/ast-dump-concepts.cpp:16
+template <typename... Ts>
+concept triple_concept = true;
+
----------------
naming suggestion: `variadic_concept`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85645/new/

https://reviews.llvm.org/D85645



More information about the cfe-commits mailing list