[PATCH] D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable

[Anatoly Trosinenko via Phabricator via cfe-commits]

atrosinenko added a comment.

Another note to myself: add `AUX_DECLS(__LibCallName)` to every generic implementation file. They were forgotten unintentionally.



================
Comment at: compiler-rt/lib/builtins/arm-libcall-overrides.h:8
+//===----------------------------------------------------------------------===//
+
+#define AEABI_RTABI __attribute__((__pcs__("aapcs")))
----------------
aaron.ballman wrote:
> It looks like you're missing a header guard, is that intentional?
Thanks, there are files such as `libcall-set-defaults.inc` that is explicitly named `.inc` due to some specific requirements at which point it should be included. But this one definitely lacks a header guard. Another question is whether it lacks a guard to check whether we are really on ARM. But it would probably be better to have something like

```lang=cpp
#if !defined(__ARM_EABI__)
# error Do not include this header unless on ARM target.
#endif
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84636/new/

https://reviews.llvm.org/D84636