[PATCH] D85590: [clang][HeaderInsert] Do not treat defines with values as header guards

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 9 23:21:33 PDT 2020


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:532
 
+TEST_F(HeaderIncludesTest, FakeHeaderGuardIfnDef) {
+  std::string Code = "#ifndef A_H\n"
----------------
could you move this to the `HeaderGuard section` of this file (~Line 349)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85590/new/

https://reviews.llvm.org/D85590



More information about the cfe-commits mailing list