[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 8 06:14:00 PDT 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a nit, but you should give other reviewers a chance to comment if they have additional feedback.



================
Comment at: clang/lib/Sema/SemaExpr.cpp:6911
+    } else if (const auto *SL = dyn_cast<StringLiteral>(InitArgList[I])) {
+      unsigned numConcat = SL->getNumConcatenated();
+      // Diagnose missing comma in string array initialization.
----------------
`numConcat` -> `NumConcat`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85545/new/

https://reviews.llvm.org/D85545



More information about the cfe-commits mailing list