[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 8 05:14:41 PDT 2020


aaron.ballman added a comment.

Should the `StructuredIndex` still be incremented even in the case of an error, as done around line 1589 and 1647? Do we need a similar change around line 2405?

I sort of wonder if the correct change is to make `UpdateStructuredListElement()` resilient to being passed a null `Expr *` and then removing the manual increments when the expression is an error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85193/new/

https://reviews.llvm.org/D85193



More information about the cfe-commits mailing list