[PATCH] D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC]

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 7 13:33:00 PDT 2020


jdoerfert added a comment.

In D85551#2203758 <https://reviews.llvm.org/D85551#2203758>, @tra wrote:

> In D85551#2203711 <https://reviews.llvm.org/D85551#2203711>, @jdoerfert wrote:
>
>> Wow, cool. I imagine it was hard to split this given the manual check lines. We really need to start using the upgrade scripts here.
>>
>> I'm fine with this, @ABataev WDYT?
>
> It was not that hard. The file had pretty uniform structure, so all it took is trivial edit to add `// CK` to `#endif` lines of individual sections and the following two commands did the rest:
>
>   csplit -f './test/OpenMP/target_map_codegen_' -b '%02d.cp'  ./test/OpenMP/target_map_codegen.cpp '/#endif \/\/\ CK/1' '{*}' 
>   for f in ./test/OpenMP/target_map_codegen_*.cp; do (head -4 ./test/OpenMP/target_map_codegen.cpp; cat $f; echo '#endif') > ${f}p; done

Very cool. Thanks for sharing this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85551/new/

https://reviews.llvm.org/D85551



More information about the cfe-commits mailing list