[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 7 01:26:27 PDT 2020


xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

I think all the problems that left should be solved in a separate patch or even out of the scope for the GSoC.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:33
 
+// Static global pointer to NullDereferenceBugType.
+static const BugType *NullDereferenceBugTypePtr;
----------------
I find this comment redundant as well. It just repeats what is already evident from the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84600/new/

https://reviews.llvm.org/D84600



More information about the cfe-commits mailing list