[PATCH] D85295: [SyntaxTree] Implement the List construct.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 6 06:05:31 PDT 2020


gribozavr2 added inline comments.


================
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:197
+  MaybeTerminated,
+  Separated,
+};
----------------
eduucaldas wrote:
> gribozavr2 wrote:
> > Add a "WithoutDelimiters" case as well?
> I think we might want to treat non-delimited-list in another way. as many of the member functions stop making sense. 
> `getElementsAsNodesAndDelimiters` 
> `getDelimiterTokenKind`
> `getTerminationKind`
OK, I'm convinced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85295/new/

https://reviews.llvm.org/D85295



More information about the cfe-commits mailing list