[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

Thu Aug 6 05:05:21 PDT 2020

sberg added a comment.

In D85287#2199463 <https://reviews.llvm.org/D85287#2199463>, @rtrieu wrote:

> Are you planning to allow this change to other warnings that use the same helper functions?

No, I didn't plan to work on this further.  Just scratching that itch of why Clang didn't emit that one warning it "obviously" should have emitted.

> Also, have you tried running warning over a codebase?

As I wrote: "At least building LibreOffice with this change caused no false positives."  (Or maybe I misunderstand your question.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85287/new/

https://reviews.llvm.org/D85287