[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 5 13:35:08 PDT 2020


efriedma added a comment.

> If the intent is for getTypeInfo to always return sizes that are multiples of the char size, then the design should be inverted and getTypeInfo should simply be calling getTypeInfoInChars and multiply that result by the char size. But that isn't how it works.

The reason it doesn't work this way is just that someone made the wrong choice a decade ago, and nobody has spent the time to rewrite it since.  Patch welcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85191/new/

https://reviews.llvm.org/D85191



More information about the cfe-commits mailing list