[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

Dan Gohman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 5 12:54:03 PDT 2020


sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

Ah, it seems the reason I didn't see this is that I wasn't using `-flax-vector-conversions=none`. Thanks for fixing this!



================
Comment at: clang/test/Headers/wasm.cpp:1
+// RUN: %clang_cc1 -triple wasm32-unknown-unknown -target-feature +simd128 -fsyntax-only -ffreestanding %s -verify
+// expected-no-diagnostics
----------------
This test currently passes on trunk without the bug fix here. Could you add a -flax-vector-conversions=none line, similar to the C test, which is the case that the patch here fixes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85347/new/

https://reviews.llvm.org/D85347



More information about the cfe-commits mailing list