[PATCH] D84622: [PowerPC] Implement Vector Extract Low/High Order Builtins in LLVM/Clang

[Amy Kwan via Phabricator via cfe-commits]

amyk accepted this revision.
amyk added a comment.

I think overall it LGTM and the indentation can be addressed when committing.



================
Comment at: clang/lib/Headers/altivec.h:17082
 
+/* vec_extractl */
+static __inline__ vector unsigned long long __ATTRS_o_ai vec_extractl(
----------------
nit: space after this comment


================
Comment at: clang/lib/Headers/altivec.h:17124
+
+/* vec_extracth */
+static __inline__ vector unsigned long long __ATTRS_o_ai vec_extracth(
----------------
nit: space after this comment


================
Comment at: clang/lib/Headers/altivec.h:17156
+static __inline__ vector unsigned long long __ATTRS_o_ai
+vec_extracth(vector unsigned long long __a, vector unsigned long long __b,
+             unsigned int __c) {
----------------
I know you said previously that having the function names in one way caused errors with clang format, but could we have the function names declared in the same way for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84622/new/

https://reviews.llvm.org/D84622