[PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Eli Friedman via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 3 13:06:12 PDT 2020


Committed dca23ed; should be fixed now.

-Eli

From: Azhar Mohammed <azhar at apple.com>
Sent: Monday, August 3, 2020 11:01 AM
To: Eli Friedman <reviews+D84703+public+194bbb12cc03c1a8 at reviews.llvm.org>; Eli Friedman via Phabricator <reviews at reviews.llvm.org>; Eli Friedman <efriedma at quicinc.com>
Cc: sander.desmalen at arm.com; sjoerd.meijer at arm.com; t.p.northover at gmail.com; cameron.mcinally at nyu.edu; blitzrakete at gmail.com; jun.l at samsung.com; Anna Welker via Phabricator via llvm-commits <llvm-commits at lists.llvm.org>; mlekena at skidmore.edu; kanheim at a-bix.com; Jonathan Coe via cfe-commits <cfe-commits at lists.llvm.org>; shenhan at google.com; kristof.beyls at arm.com; daniel.kiss at arm.com
Subject: [EXT] Re: [PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Hey Eli,

Looks like this is causing the test-suite build to fail. Can you please take a look.
Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O3/8035/consoleFull.
FAILED: SingleSource/UnitTests/Vector/AArch64/CMakeFiles/aarch64_neon_intrinsics.dir/aarch64_neon_intrinsics.c.o
/Users/buildslave/jenkins/workspace/test-suite-verify-machineinstrs-aarch64-O3/test-suite-build/tools/timeit --summary SingleSource/UnitTests/Vector/AArch64/CMakeFiles/aarch64_neon_intrinsics.dir/aarch64_neon_intrinsics.c.o.time /Users/buildslave/jenkins/workspace/test-suite-verify-machineinstrs-aarch64-O3/compiler/bin/clang -DNDEBUG -B /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin -Wno-unused-command-line-argument -mllvm -verify-machineinstrs -O3 -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.5.sdk -w -Werror=date-time -std=c99 -MD -MT SingleSource/UnitTests/Vector/AArch64/CMakeFiles/aarch64_neon_intrinsics.dir/aarch64_neon_intrinsics.c.o -MF SingleSource/UnitTests/Vector/AArch64/CMakeFiles/aarch64_neon_intrinsics.dir/aarch64_neon_intrinsics.c.o.d -o SingleSource/UnitTests/Vector/AArch64/CMakeFiles/aarch64_neon_intrinsics.dir/aarch64_neon_intrinsics.c.o -c /Users/buildslave/jenkins/workspace/test-suite-verify-machineinstrs-aarch64-O3/test-suite/SingleSource/UnitTests/Vector/AArch64/aarch64_neon_intrinsics.c
fatal error: error in backend: Cannot select: intrinsic %llvm.aarch64.neon.fcvtzs

Thanks
Azhar


On Jul 30, 2020, at 3:42 PM, Eli Friedman via Phabricator via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8dfb5d767e70: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary (authored by efriedma).

Changed prior to commit:
 https://reviews.llvm.org/D84703?vs=281052&id=282069#toc

Repository:
 rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
 https://reviews.llvm.org/D84703/new/

https://reviews.llvm.org/D84703

Files:
 clang/lib/CodeGen/CGBuiltin.cpp
 clang/test/CodeGen/aarch64-neon-fcvt-intrinsics.c
 clang/test/CodeGen/aarch64-neon-intrinsics.c
 clang/test/CodeGen/aarch64-neon-misc.c
 clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics.c
 clang/test/CodeGen/aarch64-v8.2a-neon-intrinsics.c

<D84703.282069.patch>_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200803/123bfb6c/attachment.html>


More information about the cfe-commits mailing list