[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 3 11:34:31 PDT 2020


eduucaldas added a comment.

Additionally deleting TraverseParenTypeLoc changes nothing in the tests. I can also investigate that, I can try to come up with a test that makes this Traverse override relevant and if I'm not able, I would remove this override.



================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:4080-4081
+void (X::*xp)();
+// FIXME: Generate the right syntax tree for this type,
+// i.e. create a syntax node for the outer member pointer
+void (X::Y::**xyp)(const int*, char);
----------------
I spent 15 minutes investigating that, if you think I should go further I will.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85146/new/

https://reviews.llvm.org/D85146



More information about the cfe-commits mailing list