[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 3 08:50:14 PDT 2020


balazske added a comment.

Really I am still not totally familiar how the checkers work and if it is good to have these function names. I was thinking about any checker that needs a string length information. It could get the data from CStringChecker using a "get" function or test if there is data at all. In this case it may happen that this get function modifies state or computes the length at that point? And how do the //set// operation work, it only stores a value computed by the calling code? And the //create// operation then does the computation and //set// together? The functions look not symmetrical, the set and create takes a `MemRegion` but the get takes a `SVal`. The create function sets the length for the passed memory region but makes no tests on it like the set function (can we call the set function from the create?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84979/new/

https://reviews.llvm.org/D84979



More information about the cfe-commits mailing list