[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

In D74436#2190422 <https://reviews.llvm.org/D74436#2190422>, @fhahn wrote:

> IIUC the patch is currently reverted (in 78654e8511cf16d49f6680d782f3771a767ba942 <https://reviews.llvm.org/rG78654e8511cf16d49f6680d782f3771a767ba942>), due to ~20 llvm-test-suite failures.
>
> The failures on X86 are listed below. Unfortunately most tests just compare the hash of the output, so it is not obvious in what way the results are changed.

Presumably it means that whatever optimization options those test specify, are now either more strict or less strict.
I think this is really missing some codegen tests that show how codegen actually changes by this.

> Any ideas on how to move forward on this? I'll update the diff with a rebased version on current trunk, which I used to reproduce the failures.
>
>   Failed Tests (22):
>     test-suite :: MultiSource/Applications/oggenc/oggenc.test
>     test-suite :: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMR/CLAMR.test
>     test-suite :: MultiSource/Benchmarks/DOE-ProxyApps-C++/HPCCG/HPCCG.test
>     test-suite :: MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/miniFE.test
>     test-suite :: MultiSource/Benchmarks/Rodinia/srad/srad.test
>     test-suite :: SingleSource/Benchmarks/Linpack/linpack-pc.test
>     test-suite :: SingleSource/Benchmarks/Misc-C++/Large/sphereflake.test
>     test-suite :: SingleSource/Benchmarks/Polybench/datamining/correlation/correlation.test
>     test-suite :: SingleSource/Benchmarks/Polybench/datamining/covariance/covariance.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/2mm/2mm.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/3mm/3mm.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/atax/atax.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/bicg/bicg.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/gemver/gemver.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/gesummv/gesummv.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/symm/symm.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/trisolv/trisolv.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/trmm/trmm.test
>     test-suite :: SingleSource/Benchmarks/Polybench/linear-algebra/solvers/gramschmidt/gramschmidt.test
>     test-suite :: SingleSource/Benchmarks/Polybench/stencils/adi/adi.test
>     test-suite :: SingleSource/UnitTests/Vector/SSE/Vector-sse.expandfft.test
>     test-suite :: SingleSource/UnitTests/Vector/SSE/Vector-sse.stepfft.test




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74436/new/

https://reviews.llvm.org/D74436